Thread (57 messages) flat view 57 messages, 3 authors, 2016-11-20

Re: [PATCH v7 11/17] ref-filter: introduce symref_atom_parser() and refname_atom_parser()

From: Karthik Nayak <hidden>
Date: 2016-11-12 20:13:12

On Wed, Nov 9, 2016 at 5:22 AM, Jacob Keller [off-list ref] wrote:
On Tue, Nov 8, 2016 at 12:12 PM, Karthik Nayak [off-list ref] wrote:
quoted
From: Karthik Nayak <redacted>
What's the reasoning for using separate functions here if they are
exactly identical except for name? Do we intend to add separate
options for this? I don't really have a problem with separate
functions here since it helps avoid confusion but they are identical
otherwise...
I see no need to have separate functions. Maybe in the future when we
plan on adding
specific options we could split them. I'll drop the
symref_atom_parser() function and use
refname_atom_parser() both places.

-- 
Regards,
Karthik Nayak
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help