Re: BUG: indent-with-non-tab always on
From: Marc Branchaud <hidden>
Date: 2016-08-15 17:54:19
On 2016-08-15 12:55 PM, Marc Branchaud wrote:
On 2016-08-15 11:00 AM, Philip Oakley wrote:quoted
From: "Marc Branchaud" <redacted>quoted
On 2016-08-12 07:45 PM, Philip Oakley wrote:quoted
These are the quick fixes to Marc's comments to patches 5,6,11, and a consequential change to 12. Only the changed patches are included.Looks good to me -- no further comments! However, I still don't understand why git says 11/12 has "indent with spaces" problems.I'm guessing it's that the text is monospaced rather than tabbed, and it's flagging that. I'd noticed that it was highlighted in the Git gui (which I use to visualise both the diff, the message and the part after the three dashes at the same time).Actually, it looks like an indent-with-non-tab problem, which is supposed to be off by default. Git doesn't complain about the patch if I set core.whitespace = tabwidth=11 presumably because the patch uses 10 spaces to indent the offending lines. But explicitly disabling that check with core.whitespace = -indent-with-non-tab doesn't work. Unfortunately, I don't have time today to track this down.
Gah, never mind -- didn't realize it was turned on in Documentation/.gitattributes. M.