[PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box
From: Hitoshi Mitake <hidden>
Date: 2016-08-13 23:25:17
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box · Hitoshi Mitake <hidden>
According to RFC of IMAP, all messages must not have "bare newlines ('\n')".
'\n' should be converted to "\r\n" before storing messages to IMAP's mailbox.
This patch implements the converting function to git-imap-send.
Cc: Erik Faye-Lund <redacted>
Cc: Jakub Narebski <redacted>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff King <redacted>
Signed-off-by: Hitoshi Mitake <redacted>
---
imap-send.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index dcd8a2a..dbc72ca 100644
--- a/imap-send.c
+++ b/imap-send.c@@ -1279,6 +1279,30 @@ static int imap_make_flags(int flags, char *buf) return d; } +static void lf_to_crlf(struct msg_data *msg) +{ + char *new; + int i, j, lfnum = 0; + + for (i = 0; i < msg->len; i++) { + if (msg->data[i] == '\n') + lfnum++; + } + new = xcalloc(msg->len + lfnum, sizeof(char)); + for (i = 0, j = 0; i < msg->len; i++) { + if (msg->data[i] != '\n') { + new[j++] = msg->data[i]; + continue; + } + new[j++] = '\r'; + new[j++] = '\n'; + } + msg->len += lfnum; + free(msg->data); + msg->data = new; + msg->crlf = 1; +} + static int imap_store_msg(struct store *gctx, struct msg_data *data) { struct imap_store *ctx = (struct imap_store *)gctx;
@@ -1288,6 +1312,7 @@ static int imap_store_msg(struct store *gctx, struct msg_data *data) int ret, d; char flagstr[128]; + lf_to_crlf(data); memset(&cb, 0, sizeof(cb)); cb.dlen = data->len;
--
1.6.5.2