Thread (27 messages) 27 messages, 5 authors, 15h ago
HOTtoday

[PATCH 10/13] imap-send: avoid leaking the IMAP upload buffer

From: Johannes Schindelin via GitGitGadget <hidden>
Date: 2026-07-01 07:04:49
Subsystem: the rest · Maintainer: Linus Torvalds

From: Johannes Schindelin <redacted>

When uploading messages via libcurl, curl_append_msgs_to_imap()
accumulates each one in a strbuf that grows across loop iterations
but is never released before the function returns.

Release it alongside the existing libcurl cleanup.

Reported by Coverity as CID 1671507 ("Resource leak").

Assisted-by: Opus 4.7
Signed-off-by: Johannes Schindelin <redacted>
---
 imap-send.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/imap-send.c b/imap-send.c
index cfd6a5120c..0d16d02029 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1750,6 +1750,7 @@ static int curl_append_msgs_to_imap(struct imap_server_conf *server,
 
 	curl_easy_cleanup(curl);
 	curl_global_cleanup();
+	strbuf_release(&msgbuf.buf);
 
 	if (cred.username) {
 		if (res == CURLE_OK)
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help