Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref
From: Junio C Hamano <hidden>
Date: 2016-08-11 20:34:53
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-08-11 · Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref · Johannes Schindelin <hidden>
- 2016-08-11 · Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref · Junio C Hamano <hidden>
- 2016-08-11 · Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref · Andreas Ericsson <hidden>
- 2016-08-11 · Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref · Junio C Hamano <hidden>
- 2016-08-11 · [PATCH] Documentation: Update information about <format> in git-for-each-ref · Jakub Narebski <hidden>
Jakub Narebski [off-list ref] writes:
By the way one thing missing from git-for-each-ref to use it in gitweb without changing its output is ablility to sort on "epoch", i.e. taggerdate for tags and committerdate for commits. This is needed to sort heavyweight and lightweight tags together on epoch in "summary" and "tags" views in gitweb. (It is not needed for heads/branches, but it is the tags sorting that cripples gitweb "summary" view performance.)
I guess something like this, but I haven't tested it heavily. If you want it in "next" please ack (with necessary fix-up patches if any). -- >8 -- [PATCH] for-each-ref: epoch and epochdate This adds "epoch" (which is parallel to "tagger" or "committer") and "epochdate" (corresponds to "taggerdate" and "committerdate"). As other "date" fields, "epochdate" sorts numerically and displays human readably Signed-off-by: Junio C Hamano <redacted> ---
diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
index 698618b..3dc68cc 100644
--- a/builtin-for-each-ref.c
+++ b/builtin-for-each-ref.c@@ -59,6 +59,8 @@ static struct { { "taggername" }, { "taggeremail" }, { "taggerdate", FIELD_TIME }, + { "epoch" }, + { "epochdate", FIELD_TIME }, { "subject" }, { "body" }, { "contents" },
@@ -401,6 +403,29 @@ static void grab_person(const char *who, else if (!strcmp(name + wholen, "date")) grab_date(wholine, v); } + + /* For a tag or a commit object, if "epoch" or "epochdate" is + * requested, do something special. + */ + if (strcmp(who, "tagger") && strcmp(who, "committer")) + return; /* "author" for commit object is not wanted */ + if (!wholine) + wholine = find_wholine(who, wholen, buf, sz); + if (!wholine) + return; + for (i = 0; i < used_atom_cnt; i++) { + const char *name = used_atom[i]; + struct atom_value *v = &val[i]; + if (!!deref != (*name == '*')) + continue; + if (deref) + name++; + + if (!strcmp(name, "epochdate")) + grab_date(wholine, v); + else if (!strcmp(name, "epoch")) + v->s = copy_line(wholine); + } } static void find_subpos(const char *buf, unsigned long sz, const char **sub, const char **body)