Thread (34 messages) flat view 34 messages, 5 authors, 2016-07-21

Re: [PATCH v1 4/6] Expanded branch header for Porcelain Status V2

From: Jeff King <hidden>
Date: 2016-07-20 16:07:06

On Tue, Jul 19, 2016 at 06:10:56PM -0400, Jeff Hostetler wrote:
+	} else {
+		/*
+		 * TODO All of various print routines allow for s->branch to be null.
+		 * TODO When can this happen and what should we report here?
+		 */
+		fprintf(s->fp, " %s", "(unknown)");
+	}
IIRC, it happens when HEAD points to a broken ref. So something like:

  git init
  echo broken >.git/refs/heads/master

would cause resolving HEAD to return NULL.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help