On Fri, Jun 10, 2016 at 7:04 PM, Johannes Sixt [off-list ref] wrote:

Am 10.06.2016 um 13:11 schrieb Johannes Schindelin:

quoted

Not really. The reply (which I had not quite connected with my mail
because they were over a week apart) says this:

quoted

I fixed this by moving the "close(fd)" call just after the
"apply_patch()" call.

This bug in v1 was discovered by the test suite and fixed in v2.

quoted

and this:

quoted

I will have another look at the 2 other places where there are
open()/close() or fopen()/fclose() calls.

but nothing about a careful, systematic investigation of all error code
paths. As a consequence, I fully expect to encounter test failures as soon
as I test your patch series again, simply because resources are still in
use when they should no longer be used. In other words, my expectations
are now lower than they have been before, my concerns are not at all
addressed.

Do you trust the test suite to some degree? It passes after the above bug
was fixed in v2. In addition, haven't found any problems so far during daily
use.

quoted

quoted

This is the newest iteration:

https://github.com/chriscool/git/commits/libify-apply-use-in-am65

And that cute 65 in the name is the revision.

Yeah, that number is painful. I would appreciate an unversioned branch name,
too.

Ok, you can use
https://github.com/chriscool/git/commits/libify-apply-use-in-am then.

Thanks,
Christian.