Thread (120 messages) 120 messages, 4 authors, 2016-06-16

Re: [PATCH v2 00/94] libify apply and use lib in am

From: Christian Couder <hidden>
Date: 2016-06-16 02:19:23

On Sat, May 14, 2016 at 8:26 AM, Johannes Schindelin
[off-list ref] wrote:

[...]
quoted
quoted
quoted
By the way there are no tests yet for this new feature, and I am not
sure at all that "--silent" and "be_silent" are good names.
If you want to follow existing code's example, we typically call this
option "quiet".
In the documentation there is: [... snip ...]
...

So it looks to me that --quiet means something like "don't tell the
story of your life, but in case of problem you are allowed to
complain". In other word --quiet generally doesn't suppress error
messages from error() or die().
Right.

And if you care to take a step back, this is most likely what we want in
libified code.
In the previous discussion, Junio asked:

"How far can you go with just set-error-routine?  Are there things,
other than the file descriptors, that you need to futz with in order
to covert that "we'd fallback, so this early round must be silent"
codepath?"

So it looks to me that the goal is to have something that replicate
the current behavior, which is to not even display messages from
error().

[...]
quoted
quoted
quoted
Sorry if this patch series is long. I can split it into two or more
series if it is prefered.
It is preferred. Much.
Ok, I will split it then.
Thank you. Maybe you take me off of the Cc: list, too?
Ok I will do that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help