On Mon, May 16, 2016 at 5:04 AM, Eric Sunshine [off-list ref] wrote:

On Wed, May 11, 2016 at 9:17 AM, Christian Couder
[off-list ref] wrote:

quoted

To libify `git apply` functionality we have to signal errors to the
caller instead of die()ing or exit()ing.

To do that in a compatible manner with the rest of the error handling
in builtin/apply.c, find_header() should return -1 instead of calling
die() or exit().

Why is this talking about making find_header() return -1? Didn't that
happen in the previous patch?

Yeah, it should be parse_chunk() not find_header().

This is fixed in my current branch.

Thanks,
Christian.