Re: [PATCH v5 10/15] update-index: enable/disable watchman support

On Wed, 2016-04-20 at 06:45 +0700, Duy Nguyen wrote:

On Wed, Apr 20, 2016 at 6:28 AM, David Turner <
dturner@twopensource.com> wrote:

quoted

+       if (use_watchman > 0) {
+               the_index.last_update    = xstrdup("");
+               the_index.cache_changed |= WATCHMAN_CHANGED;
+       } else if (!use_watchman) {
+               the_index.last_update    = NULL;
+               the_index.cache_changed |= WATCHMAN_CHANGED;
+       }
+

We probably should warn people if index-helper is not built with
watchman support, which makes this knob completely useless. If
watchman fails to start, that's a separate problem..

Will warn.