Re: [PATCH v5 2/6] t7030-verify-tag: Adds validation for multiple tags

On Sun, Apr 17, 2016 at 1:31 PM, Santiago Torres [off-list ref] wrote:

quoted

+       grep "^.GNUPG" <expect.stderr.1 >expect.stderr &&

Hmm, is there a reason you didn't stick with the more strict regex
Peff suggested?

    ^.GNUPG:.

(Genuine question: I'm not saying your choice is wrong, I'm just
interested in the reasoning behind the decision.)

I actually had missed the ":". I read the email and tried to internalize
what the new test was actually doing, then I rewrote the test.

I think I could add it for completeness though.

Junio already made this correction and others in the three patches he
queued on his 'pu' branch. It's possible that he also made other
tweaks not mentioned in the reviews, so it's a good idea to compare
what he queued against what you plan to send for the re-roll to ensure
that nothing is missed. Thanks.