Thread (20 messages) 20 messages, 2 authors, 2016-06-16

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

From: Eric Sunshine <hidden>
Date: 2016-06-16 02:18:40

On Tue, Apr 5, 2016 at 12:07 PM,  [off-list ref] wrote:
v5 (this):
Added helpful feedback by Eric

 * Reordering of the patches, to avoid temporal inclusion of a regression
 * Fix typos here and there.
 * Review commit messages, as some weren't representative of what the patches
   were doing anymore.
 * Updated t7030 to include Peff's suggestion, and added a helped-by line here
   as it was mostly Peff's code.
 * Updated the error-handling/printing issues that were introduced when.
   libifying the verify_tag function.
This version is a more pleasant read, easier to digest and understand.
All of my review comments were minor; nothing demanding a re-roll. As
such, this version is:

    Reviewed-by: Eric Sunshine [off-list ref]

If you do happen to re-roll based upon the review comments, feel free
to add my Reviewed-by: (but not if you make larger changes).

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help