Re: [PATCH v4 2/6] t/t7030-verify-tag.sh: Adds validation for multiple tags
From: Eric Sunshine <hidden>
Date: 2016-06-16 02:18:40
On Mon, Apr 4, 2016 at 6:22 PM, [off-list ref] wrote:
t/t7030-verify-tag.sh: Adds validation for multiple tags
Rewrite:
t7030: test verify-tag with multiple tags
The leading "t/" and the trailing "-*.sh" were dropped since they add no value.
The verify-tag command supports mutliple tag names as an argument.
s/mutliple/multiple/
However, no previous tests try to verify multiple tags at once. This test runs the verify-tag command against three tags separately and then compares the result against the invocation with the same three tags as an argument. The results shouldn't differ.
The bulk of this description is merely repeating what the patch itself
already says, thus is redundant. The entire commit message could
probably be collapsed to:
t7030: test verify-tag with multiple tags
git-verify-tag accepts multiple tags as arguments, however,
existing tests only ever invoke it with a single tag, so add a
test invoking it with multiple tags.
quoted hunk ↗ jump to hunk
Signed-off-by: Santiago Torres <redacted> ---diff --git a/t/t7030-verify-tag.sh b/t/t7030-verify-tag.sh index 4608e71..f9161332 100755 --- a/t/t7030-verify-tag.sh +++ b/t/t7030-verify-tag.sh@@ -112,4 +112,16 @@ test_expect_success GPG 'verify signatures with --raw' ' +test_expect_success GPG 'verify multiple tags' ' + tags="fourth-signed sixth-signed seventh-signed" && + for i in $tags; do + git verify-tag -v --raw $i || return 1 + done >expect.stdout 2>expect.stderr.1 && + grep GOODSIG <expect.stderr.1 >expect.stderr && + git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr.1 && + grep GOODSIG <actual.stderr.1 >actual.stderr &&
Hmm, I had expected you to adopt Peff's suggestion[1] for the greps:
grep '^.GNUPG:.' ...
[1]: http://article.gmane.org/gmane.comp.version-control.git/290691
+ test_cmp expect.stdout actual.stdout && + test_cmp expect.stderr actual.stderr +' + test_done -- 2.8.0