[PATCH v4 5/6] tag: use pgp_verify_function in tag -v call
From: <hidden>
Date: 2016-06-16 02:18:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Santiago Torres <redacted> Instead of running the verify-tag plumbing command, we use the pgp_verify_tag(). This avoids the usage of an extra fork call. To do this, we extend the number of parameters that tag.c takes, and verify-tag passes. Redundant calls done in the pgp_verify_tag function are removed. Signed-off-by: Santiago Torres <redacted> --- Note: This follows Peff's suggestion to use an adapter, instead of changing the the fn* pointer structure to match gpg_verify_tag. builtin/tag.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 1705c94..f4450f8 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c@@ -104,13 +104,7 @@ static int delete_tag(const char *name, const char *ref, static int verify_tag(const char *name, const char *ref, const unsigned char *sha1) { - const char *argv_verify_tag[] = {"verify-tag", - "-v", "SHA1_HEX", NULL}; - argv_verify_tag[2] = sha1_to_hex(sha1); - - if (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD)) - return error(_("could not verify the tag '%s'"), name); - return 0; + return gpg_verify_tag(name, GPG_VERIFY_VERBOSE); } static int do_sign(struct strbuf *buffer)
--
2.8.0