Thread (51 messages) flat view 51 messages, 6 authors, 2016-06-15

Re: [PATCH v6 28/32] config: read ref storage config on startup

From: Jeff King <hidden>
Date: 2016-06-15 23:08:33

On Mon, Feb 29, 2016 at 04:57:49PM -0500, David Turner wrote:
quoted
By the way, I notice that the default value for the_refs_backend is
"&refs_be_files". It might be safer to make this NULL (or some
&refs_be_null that fills the vtable, but just returns an error for
each
call).
In 'refs: register ref storage backends', I do make this change.  I
don't do it earlier because we don't have this config stuff in place
yet.
Ah, OK. I was that we did register the files backend as a normal one,
but I missed the assignment to NULL (I do wonder if we want a
refs_be_null to smoke out problem cases with a die("BUG") rather than
segfaulting, but in theory nobody should be doing that).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help