Thread (51 messages) flat view 51 messages, 6 authors, 2016-06-15

Re: [PATCH v6 00/32] refs backend

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:08:27

A couple of build warnings I found, haven't really read the code yet.
These two can easily be fixed

refs/lmdb-backend.c: In function 'lmdb_read_raw_ref':
refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused-variable]
  struct strbuf err = STRBUF_INIT;
                ^
refs/lmdb-backend.c: In function 'lmdb_do_for_each_ref':
refs/lmdb-backend.c:1625:15: warning: unused variable 'c' [-Wunused-variable]
   const char *c = resolve_ref_unsafe_submodule(submodule, refname, 0, oid.hash,
               ^

-Wshadow also gives a bunch of warnings, mostly about "transaction"
and "env". Whether you want to fix them is really up to you.
--
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help