Thread (51 messages) flat view 51 messages, 6 authors, 2016-06-15

Re: [PATCH v6 00/32] refs backend

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:08:28

On Fri, Feb 26, 2016 at 2:27 AM, David Turner [off-list ref] wrote:
but -Wshadow produces a ton of complaints on the rest of git's
code.   We should probably fix those.
I know, but what I wrote was meant for new code only (e.g. make
refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the
global env and transaction to the_env and the_transaction probably
does the trick. Again, this is controversial whether it's a good thing
to do. So your choice.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help