Thread (15 messages) flat view 15 messages, 3 authors, 2016-06-15

Re: [PATCH v3 2/5] tree-walk.c: remove name_compare() function

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:40

Jeremiah Mahler wrote:
Remove the duplicate name_compare() function and use the one provided by
read-cache.c.
I'd squash this into patch 1/5.
---
Notes:
    There is one small difference between the old function and the new one.
    The old one returned -N and +N whereas the new one returns -1 and +1.
    However, there is no place where the magnitude was needed, so this
    change will not alter its behavior.
This is useful information for anyone looking back at the patch in the
future, so it belongs above the three-dash divider.

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help