Thread (75 messages) flat view 75 messages, 12 authors, 2016-06-15

Re: [PATCH v4 00/13] New remote-hg helper

From: Jeff King <hidden>
Date: 2016-06-15 22:55:08

On Mon, Oct 29, 2012 at 11:02:31PM +0100, Felipe Contreras wrote:
quoted
If remote-hg is going to live in contrib, it probably makes sense to
have its tests live there, too, like subtree.
Probably, I'll check that option.

But eventually I think it should be installed by default, unless
somebody can come up for a reason not to. For now contrib might be OK.
I would one day like to have it as part of the main distribution, too,
but it would be nice to prove its worth in the field for a while first.
I especially would like to find out how it compares in practice with the
work that is in msysgit.
quoted
It means less test exposure, but the robustness of the tests does
not have to be as high.  You could also have no tests, but since you
have them, it seems silly not to include them. People know that
items in contrib/ may not be as mature as the rest of git.
Yeah, it's only a matter of figuring out how to run them.
Subtree seems to copy substantial parts of t/Makefile, but I suspect you
could get away with just using an "include". I'd also be OK with just
including a test script that pulls in test-lib.sh, and letting people
run it manually (the Makefile infrastructure is really about running a
lot of tests, but if there's only one script, it's not so hard).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help