Re: [PATCH v4 00/13] New remote-hg helper

On Mon, Oct 29, 2012 at 10:26 PM, Jeff King [off-list ref] wrote:

On Mon, Oct 29, 2012 at 03:56:39PM +0100, Felipe Contreras wrote:

quoted

quoted

quoted

I've ported the tests from hg-git and made sure that the output from remote-hg
matches the output of hg-git. With these extensive tests I would consider this
one ready for wide use. Not only do the tests pass, I've compared the generated
repos of a few projects, and the SHA-1's are exactly the same :)

Sounds cool. Unfortunately, the test script hangs for me, after starting
up xxdiff (!).

pstree reveals that it is "hg" that starts it, but I didn't investigate
beyond that.

Yeah, the test script is not ready for merging, it needs to check for
python, hg, and hg-git.

Do you have hg-git installed?

No. But it's important that it fail gracefully; I can't even take it in
pu if I can't run the test suite in a sane way.

The contrib part is fine for 'pu'. The tests aren't even meant to
exercise stuff in 'contrib', right? There might be some exceptions,
but either way, there's plenty of stuff in 'contrib' without any
tests. The tests I'm providing are simply a little sugar.

-- 
Felipe Contreras