Re: [PATCH i18n 09/11] i18n: apply: update say_patch_name to give translators complete sentence
From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:53:38
On Sun, Apr 22, 2012 at 11:42 PM, Zbigniew Jędrzejewski-Szmek [off-list ref] wrote:
On 04/16/2012 02:50 PM, Nguyễn Thái Ngọc Duy wrote:quoted
@@ -3551,8 +3555,9 @@ static int write_out_one_reject(struct patch *patch)die(_("internal error")); /* Say this even without --verbose */ - say_patch_name(stderr, "Applying patch ", patch, " with"); - fprintf(stderr, " %d rejects...\n", cnt); + strbuf_addf(&sb, _("Applying patch %%s with %d rejects..."), cnt);Shouldn't this part be: strbuf_addf(&sb, Q_("Applying patch %%s with one reject...", "Applying patch %%s with %d rejects...", cnt), cnt); ?
Yes. Thanks for catching. -- Duy