Re: 1.7.9, libcharset missing from EXTLIBS

Ævar Arnfjörð Bjarmason [off-list ref] writes:

2012/2/10 Junio C Hamano [off-list ref]:

quoted

Дилян Палаузов  [off-list ref] writes:

quoted

quoted

git 1.7.9 makes use of libcharset and /Makefile contains:

ifdef HAVE_LIBCHARSET_H
        BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
endif
...
and the problem is, that libcharset is not used when linking.  To
solve this, please replace the above extract from /Makefile with

ifdef HAVE_LIBCHARSET_H
        BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
        EXTLIBS += -lcharset
endif

[....]

I've had some similar (privately sent) bug reports about the i18n
stuff from someone who built his own Linux distro.

Basically we make assumptions that certain stuff will be in the C
library on certain platforms, certain headers go with certain
libraries etc.

Evidently none of this can really be relied upon and we'd have to
probe for each one if we wanted to make it reliable.

Well, there is always *optional* configure.ac to do detection;
"make configure; ./configure <options>" will generate config.mak.autogen
with appropriate options -- we can add autodetection if -lcharset
must be added.

-- 
Jakub Narębski