Thread (4 messages) flat view 4 messages, 4 authors, 2016-06-15

Re: 1.7.9, libcharset missing from EXTLIBS

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:53:02

Дилян Палаузов  [off-list ref] writes:
Hello,

git 1.7.9 makes use of libcharset and /Makefile contains:

ifdef HAVE_LIBCHARSET_H
        BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
endif
...
and the problem is, that libcharset is not used when linking.  To
solve this, please replace the above extract from /Makefile with

ifdef HAVE_LIBCHARSET_H
        BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
	EXTLIBS += -lcharset
endif
Thanks.

What platform is this?  Is there a guarantee that any and all system that
use "#include <libcharset.h>" has to link with "-lcharset"?

What I am wondering is there are systems that need to include the header,
but locale_charset() does not live in /lib/libcharset.a, in which case we
cannot make HAVE_LIBCHARSET_H imply use of -lcharset.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help