Re: 1.7.9, libcharset missing from EXTLIBS

Hello,

quoted

What platform is this?  Is there a guarantee that any and all system that
use "#include<libcharset.h>" has to link with "-lcharset"?

I've had some similar (privately sent) bug reports about the i18n
stuff from someone who built his own Linux distro.

I run Linux from scratch.

quoted

What I am wondering is there are systems that need to include the header,
but locale_charset() does not live in /lib/libcharset.a, in which case we
cannot make HAVE_LIBCHARSET_H imply use of -lcharset.

I do not understand this.  If you want to use a function from 
libcharset, you have to use both #include <libcharset.h> and -lcharset.

Със здраве
   Дилян

On 10.02.2012 11:06, Ævar Arnfjörð Bjarmason wrote:

2012/2/10 Junio C Hamano[off-list ref]:

quoted

Дилян Палаузов[off-list ref]  writes:

quoted

Hello,

git 1.7.9 makes use of libcharset and /Makefile contains:

ifdef HAVE_LIBCHARSET_H
         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
endif
...
and the problem is, that libcharset is not used when linking.  To
solve this, please replace the above extract from /Makefile with

ifdef HAVE_LIBCHARSET_H
         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
       EXTLIBS += -lcharset
endif

Thanks.

What platform is this?  Is there a guarantee that any and all system that
use "#include<libcharset.h>" has to link with "-lcharset"?

What I am wondering is there are systems that need to include the header,
but locale_charset() does not live in /lib/libcharset.a, in which case we
cannot make HAVE_LIBCHARSET_H imply use of -lcharset.

I've had some similar (privately sent) bug reports about the i18n
stuff from someone who built his own Linux distro.

Basically we make assumptions that certain stuff will be in the C
library on certain platforms, certain headers go with certain
libraries etc.

Evidently none of this can really be relied upon and we'd have to
probe for each one if we wanted to make it reliable.