Re: [PATCH 5/6] sequencer: Expose API to cherry-picking machinery
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:51:47
Ramkumar Ramachandra wrote:
quoted hunk ↗ jump to hunk
+++ b/sequencer.c@@ -1,8 +1,809 @@
[...]
+static const char * const revert_usage[] = {
+ "git revert [options] <commit-ish>",
+ "git revert <subcommand>",
+ NULL
+};[...]
quoted hunk ↗ jump to hunk
+++ b/sequencer.h
[...]
quoted hunk ↗ jump to hunk
@@ -25,4 +50,7 @@ struct replay_insn_list { */ void remove_sequencer_state(int aggressive); +void sequencer_parse_args(int argc, const char **argv, struct replay_opts *opts);
Another thought. I wonder if it's possible to leave sequencer_parse_args() private to builtin/revert.c, making the split a little more logical: - the builtin takes responsibility for its commandline interface - the library takes over once the builtin has figured out what the user wanted. (If another command wants to reuse some subset of cherry-pick/revert's commandline options, an appropriate function can always be exposed later.)