Re: [PATCH] For Real - Fixed pluralization in diff reports

On 8/1/2011 2:58 AM, Sverre Rabbelier wrote:

Heya,

On Mon, Aug 1, 2011 at 06:46, Jon Forrest[off-list ref]  wrote:

quoted

        fprintf(options->file, "%s", line_prefix);
        fprintf(options->file,
-              " %d files changed, %d insertions(+), %d deletions(-)\n",
-              total_files, adds, dels);
+              " %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
+              total_files, total_files == 1 ? "" : "s", adds, adds == 1 ?
"" : "s", dels,
+               dels == 1 ? "" : "s");
  }

Also, this is rather detrimental to the i18n effort methinks?

If the goal if the i18n effort is also to produce grammatically
correct output in all the supported languages then the
tests that my patch would break would have to be rewritten
anyway.

Jon