Thread (12 messages) flat view 12 messages, 5 authors, 2016-06-15

Re: [PATCH] For Real - Fixed pluralization in diff reports

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:51:42

On Mon, Aug 1, 2011 at 11:46 AM, Jon Forrest [off-list ref] wrote:
[I must have accidentally removed the "s" in "deletions" before.
I just rebuilt everything and remade the patch. All looks well
this time. This is my first submitted patch to anything
so my fingers are still learning.]

I got irritated by the

    1 files changed, 0 insertions(+), 1 deletions(-)

lack of pluralization so I fixed it. Now it says

    1 file changed, 0 insertions(+), 1 deletion(-)

and so forth.
Are you sure this does not break any tests? t3508.2 for example
hardcodes "1 insertions" and does textual compare. I have not run the
tests but I suspect it will fail.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help