Thread (105 messages) flat view 105 messages, 10 authors, 2016-06-15

Re: [PATCH v2 18/31] rebase: extract merge code to new source file

From: Jeff King <hidden>
Date: 2016-06-15 22:50:41

On Fri, Feb 25, 2011 at 12:27:03PM -0800, Jakub Narebski wrote:
quoted
quoted
Yes, sourced scripts should not have an executable bit. See 46bac90 for
rationale.
And I should have mentioned: they should go in SCRIPT_LIB in the
Makefile, not SCRIPT_SH.
Shouldn't this information be in Documentation/CodingGuidelines, and
perhaps also (checking if one doesn't accidentally change executable
bit on sourced scripts) in Documentation/SubmittingPatches?
I think it might make more sense as comments in the Makefile, which is
not very well commented for people tweaking non-config bits. Patches
welcome.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help