Thread (105 messages) flat view 105 messages, 10 authors, 2016-06-15
STALE3750d

Revision v2 of 2 in this series.

Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 30/31] rebase -i: don't read unused variable preserve_merges

From: Martin von Zweigbergk <hidden>
Date: 2016-06-15 22:50:31
Subsystem: the rest · Maintainer: Linus Torvalds

Since 8e4a91b (rebase -i: remember the settings of -v, -s and -p when
interrupted, 2007-07-08), the variable preserve_merges (then called
PRESERVE_MERGES) was detected from the state saved in
$GIT_DIR/rebase-merge in order to be used when the rebase resumed, but
its value was never actually used. The variable's value was only used
when the rebase was initated.

Signed-off-by: Martin von Zweigbergk <redacted>
---
Changes since v1:

 * Added back call to get_saved_options that I had removed by mistake
   while reordering commits.

 git-rebase--interactive.sh |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 5773b75..cf19bf5 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -583,7 +583,6 @@ skip_unnecessary_picks () {
 }
 
 get_saved_options () {
-	test -d "$rewritten" && preserve_merges=t
 	test -f "$state_dir"/rebase-root && rebase_root=t
 }
 
-- 
1.7.4.rc2.33.g8a14f
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help