Thread (11 messages) flat view 11 messages, 3 authors, 2016-06-15
DORMANTno replies

[PATCH 1/2] git-gui: fetch/prune all entry only for more than one entry

From: Heiko Voigt <hidden>
Date: 2016-06-15 22:50:38
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

In case there is only one remote a fetch/prune all entry
is redundant.

Signed-off-by: Heiko Voigt <redacted>
---

On Tue, Feb 22, 2011 at 07:36:23PM +0100, Jens Lehmann wrote:
1) It would be nice if the new menu entry would only appear when there
   is more than one remote to fetch from.
How about this? Disclaimer: Only superficially tested on OSX.

 lib/remote.tcl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/remote.tcl b/lib/remote.tcl
index 42d2061..18d3d06 100644
--- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -237,13 +237,13 @@ proc update_all_remotes_menu_entry {} {
 
 	set have_remote 0
 	foreach r $all_remotes {
-		set have_remote 1
+		incr have_remote
 	}
 
 	set remote_m .mbar.remote
 	set fetch_m $remote_m.fetch
 	set prune_m $remote_m.prune
-	if {$have_remote} {
+	if {$have_remote > 1} {
 		make_sure_remote_submenues_exist $remote_m
 		set index [expr {[$fetch_m type 0] eq "tearoff" ? 1 : 0}]
 		if {[$fetch_m entrycget $index -label] ne "All"} {
-- 
1.7.4.1.30.gd0a3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help