Thread (11 messages) flat view 11 messages, 3 authors, 2016-06-15
STALE3733d

[PATCH 1/2] git-gui: fix deleting item from all_remotes variable

From: Heiko Voigt <hidden>
Date: 2016-06-15 22:50:33
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

lsearch and lreplace both take the variable content as argument and not
just their name.

Signed-off-by: Heiko Voigt <redacted>
---
 lib/remote.tcl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/remote.tcl b/lib/remote.tcl
index b92b429..1383e97 100644
--- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -264,8 +264,8 @@ proc remove_remote {name} {
 		unset repo_config(remote.$name.push)
 	}
 
-	set i [lsearch -exact all_remotes $name]
-	lreplace all_remotes $i $i
+	set i [lsearch -exact $all_remotes $name]
+	set all_remotes [lreplace $all_remotes $i $i]
 
 	set remote_m .mbar.remote
 	delete_from_menu $remote_m.fetch $name
-- 
1.7.4.34.gd2cb1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help