Re: Re: [PATCH 1/2] git-gui: fix deleting item from all_remotes variable
From: Heiko Voigt <hidden>
Date: 2016-06-15 22:50:33
Hi Pat, On Sun, Feb 13, 2011 at 01:20:14PM +0000, Pat Thoyts wrote:
On 12 February 2011 16:43, Heiko Voigt [off-list ref] wrote:quoted
lsearch and lreplace both take the variable content as argument and not just their name. Signed-off-by: Heiko Voigt <redacted> --- lib/remote.tcl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/lib/remote.tcl b/lib/remote.tcl index b92b429..1383e97 100644 --- a/lib/remote.tcl +++ b/lib/remote.tcl@@ -264,8 +264,8 @@ proc remove_remote {name} {unset repo_config(remote.$name.push) } - set i [lsearch -exact all_remotes $name] - lreplace all_remotes $i $i + set i [lsearch -exact $all_remotes $name] + set all_remotes [lreplace $all_remotes $i $i]
If you were going to please wait with applying it. I just found another location where this variable is changed in a wrong manner. I will update the patch accordingly. Cheers Heiko