Re: [1.8.0] forbid full fetchspecs in git-pull

On Tue, Feb 01, 2011 at 04:14:57PM +0100, Thomas Rast wrote:

Dmitry Potapov wrote:

quoted

As to disallowing ':' in refspec completely, I am not so sure... Not
that I think it is very useful, but also I don't see how it can hurt
someone provided that the target branch cannot be the current branch.

_
IRC experience shows that people, while on some topic branch, run
_
  git pull origin master:master
_
expecting it to "pull master into master" (or even worse with three
different branch names).  So no, the current branch safeguard does
not prevent the fundamental mistake.

I am not sure what you mean by three different branches names. You
referred to item 1, and I agree it is confusing, but it can be prevented
by the current branch safeguard.

and the current semantic of "git pull" is very clear:

"git pull repo refspec" = "git fetch repo refspec && git merge FETCH_HEAD"

IMHO, the full confusion was caused by incorrect information on github,
which was corrected a long time ago. Have you heard about any new
users who are confused by git-pull?

And if we really want to disallow ':' in git pull refspec then the
documentation should be corrected too. For instance, if there are
options to git fetch that make no sense if you cannot specify lbranch.
Also description of refspec should be corrected in git pull man page.


Dmitry