Re: [1.8.0] forbid full fetchspecs in git-pull
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:29
Thomas Rast [off-list ref] writes:
Proposal: git-pull inherits the full fetchspec invocation syntax from git-fetch, so that you can do e.g. git pull origin master:master usually shooting yourself in the foot in the process. See e.g. http://thread.gmane.org/gmane.comp.version-control.git/130819/focus=130879 [item 1] Prohibit this invocation, i.e., disallow any second argument to git-pull that contains ':'. History: I submitted a patch ages ago: http://article.gmane.org/gmane.comp.version-control.git/130822 Sean seemed to be the only one in favour of the old behaviour, but I was too lazy to push it past him. (There were some issues with the test as well.)
As I summarized in $gmane/135813 I don't think there was any objection against forbidding "git pull" with refspec with colon. There indeed was an interesting tangent topic that was about valid use cases of "git fetch" with such refspec, but I think this is orthogonal to that issue.