Re: [PATCH 12/13] git-remote-testgit: only push for non-local repositories

Heya,

On Sun, Aug 29, 2010 at 20:48, Jonathan Nieder [off-list ref] wrote:

[warning: I have not read through remote-testgit carefully]

Could you explain further?  I see

 ERROR: could not find repo at .git/info/fast-import/4dc49bf026b65e6a1b28e2457d4d6393af8d382c/.git

The repo in .git/info/... is only there iff the remote repo is not on
disk. If the remote _is_ on disk (i.e., repo.is_local),
`repo.importer.do_import(repo.gitdir)` will have directly updated the
remote. For remotes that are not on disk (i.e., not repo.is_local),
`repo.importer.do_import(repo.gitdir)` will have instead updated a
on-disk clone of the remote, which is stored in .git/info/...

So, to answer your question:

but I do not know why there should have been a repo there

There should be a repo there only if the remote is not on disk.

or why we would
not want to do the equivalent of

 git push . refs/testgit/origin/refs/heads/master:refs/heads/master

That isn't needed since the importer has already done that.

-- 
Cheers,

Sverre Rabbelier