Re: [PATCH 10/13] transport-helper: implement marks location as capability
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:24
Sverre Rabbelier wrote:
quoted hunk ↗ jump to hunk
--- a/git-remote-testgit.py +++ b/git-remote-testgit.py@@ -71,8 +71,24 @@ def do_capabilities(repo, args): print "import" print "export" print "gitdir" + + sys.stdout.flush() + if not read_one_line(repo): + die("Expected gitdir, got empty line")
This seems fragile to me: shouldn't the remote helper check somehow that the line it read was actually a gitdir line? No other complaint on my part. Requiring a flush seems entirely appropriate to me, and if someone comes up with something nicer than the "capabilities" sequence for requesting information, it would not be the end of the world to have two ways to discover the .git dir.