Sverre Rabbelier wrote:
quoted hunk ↗ jump to hunk
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -410,8 +412,11 @@ static int fetch_with_import(struct transport *transport,
sendline(data, &buf);
strbuf_reset(&buf);
}
- disconnect_helper(transport);
- finish_command(&fastimport);
+ if(disconnect_helper(transport))
+ die("Error while disconnecting helper");
+ if (finish_command(&fastimport))
+ die("Error while running fast-import");
Nit: missing space after "if".
quoted hunk ↗ jump to hunk
+
free(fastimport.argv);
fastimport.argv = NULL;
@@ -751,8 +756,10 @@ static int push_refs_with_export(struct transport *transport,
die("Couldn't run fast-export");
data->no_disconnect_req = 1;
- finish_command(&exporter);
- disconnect_helper(transport);
+ if(finish_command(&exporter))
+ die("Error while running fast-export");
+ if(disconnect_helper(transport))
Likewise.
Thanks for this. A test would be nice if someone has time to write
one.