Re: Compiling git with makepp patch

  la 08/24/2010 06:32 AM Jonathan Nieder skribis:

Hi,

Daniel Pfeiffer wrote:

quoted

The file needs to be built immediately so
that it can be included, before reading the rest of the makefile.
But the dependency is only known to be phony after running the rule.
Here you have a hen-egg problem, where I have no clue how Gnu make
can cope (this is the one case where it requires .PHONY).

GNU make, unlike, say, pmake, reads all the rules before it runs
anything iirc.  So you can have

  -include foo

  foo:
	echo bar:>foo
	echo '	echo hi'>>foo

and it will cope okay.

While that is not the usual use-case for -include, the file might very well 
define some macros, and the rest of the makefile, indeed the foo-rule itself 
might depend on those macros.  Better to have things in a clear order!

Anyway, the git makefile is very far from topologically sorted; if
you are suggesting we change that, that's fine with me, as long as
the new rule is somehow justified and consistent.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

-- 
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                     http://lernu.net  /  http://ikurso.net