Thread (8 messages) flat view 8 messages, 5 authors, 2016-06-15

Re: Compiling git with makepp patch

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:22

Hi,

Daniel Pfeiffer wrote:
.PHONY: FORCE

I don't know why you depend on a phony that has no rule — I also had
to make that possible.
Surely the name explains it. :)
The file needs to be built immediately so
that it can be included, before reading the rest of the makefile.
But the dependency is only known to be phony after running the rule.
Here you have a hen-egg problem, where I have no clue how Gnu make
can cope (this is the one case where it requires .PHONY).
GNU make, unlike, say, pmake, reads all the rules before it runs
anything iirc.  So you can have

 -include foo

 foo:
	echo bar: >foo
	echo '	echo hi' >>foo

and it will cope okay.

Anyway, the git makefile is very far from topologically sorted; if
you are suggesting we change that, that's fine with me, as long as
the new rule is somehow justified and consistent.

Hope that helps,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help