Re: Compiling git with makepp patch

From
Ævar Arnfjörð Bjarmason <hidden>
Date
2016-06-15 22:49:22
Reply to
Daniel Pfeiffer, 2016-06-15
On Sun, Aug 22, 2010 at 22:31, Daniel Pfeiffer [off-list ref] wrote:
Git has been giving our promise of Gnu make compatibility a hard
time.
Aside from our bugs you can't make that promise if projects like Git
need patches to work with makepp :)
The other thing caused me quite a headache before I understood:

PERL_PATH_SQ  = $(subst ','\'',$(PERL_PATH))#'

I suppose you added the comment for Emacs' syntax highlighting, to have an
even number of unescaped quotes.
That was added by John 'Warthog9' Hawley, I wonder if that also came
with a M-x report-emacs-bug, e.g. cperl-mode deals with that case,
sounds like an easy-to-fix bug in makefile-gmake-mode.
The problem is makepp parses this line
just like Emacs, so it doesn't find the comment, adding in the #' at the
point of use, which completely screws the sed command.  (You might want to
apply my fix to a few other makefiles, which have SQ variables, albeit
without the syntax highlighting workaround, so they are only visually
defect.)
The reason Emacs has issues is because it uses an ad-hoc regexp based
parser that favours speed above correctness for syntax
highlighting.

I'm surprised you've gotten this far with makepp if you don't tokenize
comments and throw their contents away.
Thread (8 messages) 8 messages, 5 authors, last reply 2016-06-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help