Re: [PATCH] t/README: clarify test_must_fail description

On Tue, Jul 20, 2010 at 21:12, Brandon Casey [off-list ref] wrote:

On 07/20/2010 03:49 PM, Ævar Arnfjörð Bjarmason wrote:

quoted

On Tue, Jul 20, 2010 at 19:16, Jonathan Nieder [off-list ref] wrote:

quoted

Ęvar Arnfjörš Bjarmason wrote:

quoted

That's what we seem to be doing in the tests so far, i.e. test_must_fail
is reserved for git commands only.

test_must_fail relies on conventions for return value that cannot
necessarily be relied on from outside utilities.

Right, someone should send a patch for these:

    ack 'test_must_fail (?!git)' *sh

:)

You joke, but thanks to your prodding, I discovered these broken
tests that should definitely all be fixed:

Oh I'm completely serious, I'm just too lazy to do these myself today :)

  $ perl -ne 'm/test_must_fail +[^ ]+=/ && print' *sh

       test_must_fail PAGER= git reflog show delta &&
       test_must_fail PAGER= git reflog show epsilon &&
       test_must_fail PAGER= git reflog show epsilon
       test_must_fail PAGER= git reflog show zeta &&
       test_must_fail PAGER= git reflog show eta &&
       test_must_fail PAGER= git reflog show eta
       test_must_fail PAGER= git reflog show beta
       test_must_fail MSG="yet another note" git notes add -c deadbeef &&

one-shot variable assignment does not work with test_must_fail.

See e2007832552ccea9befed9003580c494f09e666e for an explanation.

Good catch.