Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:49:09
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail · Erick Mattos <hidden>
- 2016-06-15 · Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail · Brandon Casey <hidden>
On Wed, Jul 21, 2010 at 00:01, Jonathan Nieder [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Ævar Arnfjörð Bjarmason wrote:quoted
You must use "export PAGER;", not "export PAGER &&". export doesn't return zero on all systems when exporting, see previous changes in this regard in t/.Nope. Sorry I missed this before.diff --git a/t/README b/t/README index b906ceb..f81998b 100644 --- a/t/README +++ b/t/README@@ -259,11 +259,11 @@ Do:test ... That way all of the commands in your tests will succeed or fail. If - you must ignore the return value of something (e.g. the return - value of export is unportable) it's best to indicate so explicitly - with a semicolon: + you must ignore the return value of something (e.g., the return + after unsetting a variable that was already unset is unportable) it's + best to indicate so explicitly with a semicolon:
We should have examples for both export and unset, but the prose should mention both IMO