Re: [PATCH] Convert "! git" to "test_must_fail" git.

On 07/20/2010 02:48 PM, Jonathan Nieder wrote:

Brandon Casey wrote:

quoted

I believe the '!' negates the
result of the entire statement, but test_must_fail only
operates on the arguments preceding the '|'.

Right.  For example:

quoted

On 07/20/2010 02:09 PM, Jared Hance wrote:

[...]

quoted

quoted

+++ b/t/t7810-grep.sh

@@ -134,7 +134,7 @@ do
 	'
 
 	test_expect_success "grep -c $L (no /dev/null)" '
-		! git grep -c test $H | grep /dev/null
+		test_must_fail git grep -c test $H | grep /dev/null

should be

	git grep -c test $H | ! grep /dev/null

I seem to recall that that doesn't work either.

   $ /bin/bash -c 'echo foo | ! grep bar && echo success || echo failure'
   /bin/bash: -c: line 0: syntax error near unexpected token `!'
   /bin/bash: -c: line 0: `echo foo | ! grep bar && echo success || echo failure'

-brandon