Thread (9 messages) 9 messages, 6 authors, 2016-06-15

Re: [PATCH] Convert "! git" to "test_must_fail" git.

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:49:09

Brandon Casey wrote:
I believe the '!' negates the
result of the entire statement, but test_must_fail only
operates on the arguments preceding the '|'.
Right.  For example:
On 07/20/2010 02:09 PM, Jared Hance wrote:
[...]
quoted
+++ b/t/t7810-grep.sh
@@ -134,7 +134,7 @@ do
 	'
 
 	test_expect_success "grep -c $L (no /dev/null)" '
-		! git grep -c test $H | grep /dev/null
+		test_must_fail git grep -c test $H | grep /dev/null
should be

	git grep -c test $H | ! grep /dev/null

or if it is considered important to test the exit code of
git grep,

	git grep -c test $H >actual &&
	! grep /dev/null actual

Regards,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help