Re: [patch 00/15] Portability Patches v3

On 03/16/2010 12:42 AM, Gary V. Vaughan wrote:

Here are the portability patches we needed at TWW to enable
git-1.7.0.2 to compile and run on all of the wide range of Unix
machines we support.  These patches apply to the git-1.7.0.2 release,
and address all of the feedback from the previous two times I posted
them to this list, most particularly splitting everything into many
small self-contained chunks.

Note that I have not invested the time to figure out why the testsuite
is mostly useless on everything but Linux and Solaris 8+, because I'm
reasonably satisfied that the build itself is working properly.  Most
likely, it is merely GNUisms in the way the test cases call external
tools.  But maybe I'm missing something, but even the 3 new patches to
address test errors when diff does not support the -u option don't
improve the testsuite situation on HPUX, AIX, OSF1 and Solaris 7 and
older.

Which shell are you using?  If you're trying to use Korn or /usr/xpg4/bin/sh
on Solaris, you'll have problems, but it is possible.  I can send you a
patch.

I have 3 patches that I apply on top of master which allows me to compile and
test on Solaris 7.  I remove all but the first when installing, since it is
necessary to compile and the others are only necessary for the test suite.

  1) Remove const declaration from arrays with non-constant initializers
  2) t5100/*.mbox: use '646' rather than 'us-ascii' for Solaris
  3) t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODE


Here's the config.mak file I use:

GIT_SKIP_TESTS := \
   t1304.3 \
   t3900.2[23] \
   t5000.1[5-79] t5000.2[013-6] t5000.41 \
   t6030.1[23] \
   t8005.[23]

GIT_TEST_CMP = cmp -s

export GIT_SKIP_TESTS GIT_TEST_CMP

SHELL_PATH = /usr/xpg4/bin/sh

# This is an old GNU tar that's why some of the
# tests in t5000? still fail
TAR = /apps/bin/gtar

CC = /opt/SUNWspro/bin/cc

# zlib is installed in /apps
CFLAGS = -fast -native -I/apps/include
LDFLAGS = -L/apps/lib

NO_CURL = 1
NO_TCLTK = 1
NO_OPENSSL = 1
BLK_SHA1 = 1
NO_PYTHON = 1
DEFAULT_PAGER = more

-brandon