Re: [PATCH v2 13/13] Add Python support library for remote helpers

On Wednesday 04 November 2009, Sverre Rabbelier wrote:

This patch introduces parts of a Python package called
"git_remote_helpers" containing the building blocks for
python helper.
The actual remote helpers itself are NOT part of this patch.

The patch includes the necessary Makefile additions to build and install
the git_remote_cvs Python package along with the rest of Git.

There are a few typos in the above. How about:

  This patch introduces parts of a Python package called
  "git_remote_helpers" containing the building blocks for
  remote helpers written in Python.
  No actual remote helpers are part of this patch, the patch
  only includes the common basics needed to start writing such
  helpers.

The patch includes the necessary Makefile additions to build and install
the git_remote_cvs Python package along with the rest of Git.

s/git_remote_cvs/git_remote_helpers/

This patch is based on Johan Herland's git_remote_cvs patch and
has been improved by the following contributions:
- David Aguilar: Lots of Python coding style fixes
- David Aguilar: DESTDIR support in Makefile

Cc: David Aguilar <redacted>
Cc: Johan Herland <redacted>
Signed-off-by: Sverre Rabbelier <redacted>
---

Otherwise it all looks good. Nice work!


...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net