[PATCH v2 01/13] Fix memory leak in helper method for disconnect
From: Sverre Rabbelier <hidden>
Date: 2016-06-15 22:47:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Daniel Barkalow <redacted> Since some cases may need to disconnect from the helper and reconnect, wrap the function that just disconnects in a function that also frees transport->data. Signed-off-by: Daniel Barkalow <redacted> --- Moved to the beginning of the series as it is most important. transport-helper.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index f57e84c..e24fcbb 100644
--- a/transport-helper.c
+++ b/transport-helper.c@@ -67,6 +67,13 @@ static int disconnect_helper(struct transport *transport) return 0; } +static int release_helper(struct transport *transport) +{ + disconnect_helper(transport); + free(transport->data); + return 0; +} + static int fetch_with_fetch(struct transport *transport, int nr_heads, const struct ref **to_fetch) {
@@ -163,6 +170,6 @@ int transport_helper_init(struct transport *transport, const char *name) transport->data = data; transport->get_refs_list = get_refs_list; transport->fetch = fetch; - transport->disconnect = disconnect_helper; + transport->disconnect = release_helper; return 0; }
--
1.6.5.2.295.g0d105