Thread (21 messages) flat view 21 messages, 5 authors, 2016-06-15

Re: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git

From: Frank Li <hidden>
Date: 2016-06-15 22:47:16

How about this instead?

	Define SNPRINTF_SIZE_CORR=1 for Microsoft Visual C++

	The Microsoft C runtime's vsnprintf function does not add NUL at
	the end of the buffer.

	Further, Microsoft deprecated vsnprintf in favor of _vsnprintf, so
	add a #define to that end.
Of course,  do you need me change commit comment and resend patch?
The patch is good, although I suspect that the definition of vsnprintf is
better handled in the precompiler options in .vcproj.
If define in .vcproj, it needs copy that to DEBUG\RELEASE and 32bit\64bit (2x2)
4 places. It is easy to miss one.
Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help