Re: [PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit.

Hi,

On Tue, 18 Aug 2009, Frank Li wrote:

Signed-off-by: Frank Li <redacted>

How about

	Test whether WIN32 is defined rather than __MINGW32__

	The code which is conditional on MinGW32 is actually conditional 
	on Windows.  So test WIN32 rather than __MINGW32__.

	This does not break Cygwin builds, as WIN32 is undefined there.

	Suggested by Dmitry Potapov

?

Of course, you have to edit your patch accordingly, then.

And yes, I just tested, WIN32 is indeed defined on MinGw32.

Ciao,
Dscho