[PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c · Frank Li <hidden> · 2016-06-15
[PATCH 02/11] Fix declare variable at mid of function · Frank Li <hidden> · 2016-06-15
[PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git · Frank Li <hidden> · 2016-06-15
[PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit. · Frank Li <hidden> · 2016-06-15
Re: [PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit. · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit. · Frank Li <hidden> · 2016-06-15
Re: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git · Frank Li <hidden> · 2016-06-15
Re: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 02/11] Fix declare variable at mid of function · Reece Dunn <hidden> · 2016-06-15
Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Schindelin <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Marius Storm-Olsen <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Schindelin <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Frank Li <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Schindelin <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Sixt <hidden> · 2016-06-15
Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Schindelin <hidden> · 2016-06-15
Re: [msysGit] Re: [PATCH 02/11] Fix declare variable at mid of function · Johannes Sixt <hidden> · 2016-06-15
Re: [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c · Frank Li <hidden> · 2016-06-15

Re: [PATCH 02/11] Fix declare variable at mid of function

From: Reece Dunn <hidden>
Date: 2016-06-15 22:47:15

2009/8/17 Johannes Schindelin [off-list ref]:

Hi,

On Tue, 18 Aug 2009, Frank Li wrote:

quoted

Some compiler such as MSVC can't support declear variable at mid of funtion at c file.

Please wrap your commit messages after 76 characters.

quoted

Signed-off-by: Frank Li <redacted>
---

How about this instead?

       Avoid declaration after instruction

       Microsoft Visual C++ does not understand this C99 style.

?

The patch itself is good.

Shouldn't GCC be changed to use -std=c89 as well to pick up errors for
compilers that don't support c99 (like the Microsoft Visual C++ C
compiler)?

- Reece

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help